arch@glassfish.java.net

Re: Review of Monitoring one-pager: new section on enable/disable-monitoring

From: Bill Shannon <bill.shannon_at_sun.com>
Date: Thu, 17 Sep 2009 21:00:26 -0700

Sreenivas Munnangi wrote on 9/17/09 6:59 PM:
>> What process does the pid refer to?
>
> Application server's jvm process.

Is enable-monitoring a local command or a remote command?
I assume it's a local command.

If there were a way to get the pid from the server would that
avoid the need for this option?

>> What is the set of valid options to --options? Perhaps it should be
>> called
>> --property for consistency with other commands?
>
> These are the options for btrace-agent and they are
> dumpClasses=false,debug=false,unsfae=false,probeDescPath=/foo/bar,noServer=true,script=$1

Does seem kind of like properties but I'll let you decide which name
is best. If you want commas as the delimiter instead of colon, it
definitely should *not* be --property.

>> What are the valid values for --level?
>>
> OFF, LOW and HIGH

No, what are the set of things that you can set to OFF, LOW, or HIGH?