admin@glassfish.java.net

Code review take 2: nodeagents -> nodes

From: Joe Di Pol <joe.dipol_at_oracle.com>
Date: Thu, 12 Aug 2010 11:03:15 -0700

Bill Shannon wrote:
> The only real issue is that I didn't see the code that would handle the
> upgrade case and rename the directory.

I've gone ahead and implemented an upgrade service to
do the rename. Please let me know if this is the wrong
place to do this:

New file:
main/java/com/sun/enterprise/admin/servermgmt/UpgradeFilesystem.java

/*
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
  *
  * Copyright 2010 Sun Microsystems, Inc. All rights reserved.
  *
  * The contents of this file are subject to the terms of either the GNU
  * General Public License Version 2 only ("GPL") or the Common Development
  * and Distribution License("CDDL") (collectively, the "License"). You
  * may not use this file except in compliance with the License. You can obtain
  * a copy of the License at https://glassfish.dev.java.net/public/CDDL+GPL.html
  * or glassfish/bootstrap/legal/LICENSE.txt. See the License for the specific
  * language governing permissions and limitations under the License.
  *
  * When distributing the software, include this License Header Notice in each
  * file and include the License file at glassfish/bootstrap/legal/LICENSE.txt.
  * Sun designates this particular file as subject to the "Classpath" exception
  * as provided by Sun in the GPL Version 2 section of the License file that
  * accompanied this code. If applicable, add the following below the License
  * Header, with the fields enclosed by brackets [] replaced by your own
  * identifying information: "Portions Copyrighted [year]
  * [name of copyright owner]"
  *
  * Contributor(s):
  *
  * If you wish your version of this file to be governed by only the CDDL or
  * only the GPL Version 2, indicate your decision by adding "[Contributor]
  * elects to include this software in this distribution under the [CDDL or GPL
  * Version 2] license." If you don't indicate a single choice of license, a
  * recipient has the option to distribute your version of this file under
  * either the CDDL, the GPL Version 2 or to extend the choice of license to
  * its licensees as provided above. However, if you add GPL Version 2 code
  * and therefore, elected the GPL Version 2 license, then the option applies
  * only if the new code is made subject to such option by the copyright
  * holder.
  */

package com.sun.enterprise.admin.servermgmt;

import com.sun.enterprise.util.SystemPropertyConstants;

import org.jvnet.hk2.annotations.Service;
import org.jvnet.hk2.component.PostConstruct;
import org.glassfish.api.admin.config.ConfigurationUpgrade;

import java.io.File;
import java.util.logging.Logger;
import java.util.logging.Level;

/**
  * Startup service to update the filesystem from v2 to the v3 format
  *
  * @author Joe Di Pol
  */
@Service
public class UpgradeFilesystem implements ConfigurationUpgrade, PostConstruct {


     @Override
     public void postConstruct() {
         upgradeFilesystem();
     }

     private void upgradeFilesystem() {

         // Rename nodeagents to nodes
         String installDir = System.getProperty(
                 SystemPropertyConstants.INSTALL_ROOT_PROPERTY);

         File agentsDir = new File(installDir, "nodeagents");
         File nodesDir = new File(installDir, "nodes");

         // Only do this if nodeagents exists and nodes does not
         if (agentsDir.exists() && ! nodesDir.exists() ) {
             String msg = "Renaming " + agentsDir.getPath() +
                         " to " + nodesDir.getPath();
             Logger.getAnonymousLogger().log(Level.INFO, msg);
             if ( ! agentsDir.renameTo(nodesDir)) {
                 msg = "Failed to rename " + agentsDir.getPath() +
                         " to " + nodesDir.getPath();
                 Logger.getAnonymousLogger().log(Level.SEVERE, msg);
             }
         }
     }
}