Joe Di Pol wrote on 08/11/2010 03:41 PM:
>
> I'm looking for a couple of eyeballs to take a quick look at this
> since it is fairly wide-ranging. The fix is for:
>
> Rename "nodeagents" dir to "nodes"
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=12640
>
> This changes the name of the "nodeagents" directory to "nodes".
> I've grep'd the source and changed all occurrences that seemed
> relevant. I've run quicklook and the admin dev tests and so
> far all is well (I did need to modify a couple dev tests -- those
> changes are not included here).
>
> The change is pretty boring -- what I'm really looking for
> is if there is anything obvious that I've missed.
There were several field and method names that could've been renamed to
remove the "agent" part, e.g., "agentsDir" -> "nodesDir". Extra credit
if you fix those.
The only real issue is that I didn't see the code that would handle the
upgrade case and rename the directory.