admin@glassfish.java.net

Re: Code review: nodeagents -> nodes

From: Joe Di Pol <joe.dipol_at_oracle.com>
Date: Thu, 12 Aug 2010 08:54:41 -0700

Bill Shannon wrote:
> Joe Di Pol wrote on 08/11/2010 03:41 PM:
> There were several field and method names that could've been renamed to
> remove the "agent" part, e.g., "agentsDir" -> "nodesDir". Extra credit
> if you fix those.

To minimize the change I decided not to go there. If I get motivated
maybe I'll do this early in MS5.

> The only real issue is that I didn't see the code that would handle the
> upgrade case and rename the directory.

Correct. It's unclear to me if this is needed for the v2 -> v3
upgrade case, although it would help the v3 build-to-build
case.

Does anybody have an existing example of an upgrade task that is being
run at startup that I can look at to see how it is done?

Thanks,

Joe

>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>