admin@glassfish.java.net

Re: review request for admingui submodules' pom.xml

From: Jane Young <jane.young_at_oracle.com>
Date: Mon, 21 Jun 2010 13:22:40 -0700

There is a Unix utility called: dos2unix.


Anissa Lam wrote:
>
>
> On 6/21/10 1:08 PM, Jane Young wrote:
>> Looks good. One suggestion, you may want to define the plugin in
>> v3/pom.xml's pluginManangement element
>> <plugin>
>> <groupId>org.apache.maven.plugins</groupId>
>> <artifactId>maven-clean-plugin<</artifactId>
>> <version>2.4.1</version>
>> </plugin>
>> This is so that the version is defined in one central location. In
>> the submodule pom files, remove the version element.
> Thanks for the suggestion, will do that.
>>
>> Also, several files have "^M". Can you fix it before committing?
> I saw that too. I was using NetBeans to add those lines. ^M doesn't
> show up there. I guess some of those files already has ^M in all the
> lines, and NB is 'smart' enough to follow that pattern ?
> I tried to use vi to remove the ^M, but it said pattern not found. I
> will found a way to do that before checking in.
>
> thanks
> Anissa
>
>
>>
>> Thanks,
>> Jane
>>
>> Anissa Lam wrote:
>>>
>>> Hi Jane,
>>> I have modified the admingui sub-modules pom.xml to add
>>> maven-clean-plugin as you suggested. I have tested and it works as
>>> expected.
>>> Please review and let me know if i can checkin.
>>>
>>> thanks
>>> Anissa.
>>>
>>