Hi Jane,
Turns out the version for maven-clean-plugin has already be defined in
v3/pom.xml, so i just remove the version element in my changes.
Also, Ken pointed out that i can set a property for eol style by doing:
/ svn propset svn:eol-style native pom.xml/
Thats what i did to the pom files to fix the ^M issue.
Changes are checked in, thanks.
Anissa.
On 6/21/10 1:22 PM, Jane Young wrote:
> There is a Unix utility called: dos2unix.
>
>
> Anissa Lam wrote:
>>
>>
>> On 6/21/10 1:08 PM, Jane Young wrote:
>>> Looks good. One suggestion, you may want to define the plugin in
>>> v3/pom.xml's pluginManangement element
>>> <plugin>
>>> <groupId>org.apache.maven.plugins</groupId>
>>> <artifactId>maven-clean-plugin<</artifactId>
>>> <version>2.4.1</version>
>>> </plugin>
>>> This is so that the version is defined in one central location. In
>>> the submodule pom files, remove the version element.
>> Thanks for the suggestion, will do that.
>>>
>>> Also, several files have "^M". Can you fix it before committing?
>> I saw that too. I was using NetBeans to add those lines. ^M doesn't
>> show up there. I guess some of those files already has ^M in all the
>> lines, and NB is 'smart' enough to follow that pattern ?
>> I tried to use vi to remove the ^M, but it said pattern not found.
>> I will found a way to do that before checking in.
>>
>> thanks
>> Anissa
>>
>>
>>>
>>> Thanks,
>>> Jane
>>>
>>> Anissa Lam wrote:
>>>>
>>>> Hi Jane,
>>>> I have modified the admingui sub-modules pom.xml to add
>>>> maven-clean-plugin as you suggested. I have tested and it works as
>>>> expected.
>>>> Please review and let me know if i can checkin.
>>>>
>>>> thanks
>>>> Anissa.
>>>>
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>