On 4/7/2010 6:28 AM, Jennifer Chou wrote:
>
>
> On 4/8/2010 9:59 AM, Jerome Dochez wrote:
>> I can see 2 disadvantages :
>>
>> 1. the default-config.xml was separated from the domain.xml meaning
>> it was surviving the domain deletion or supporting the multi domain
>> situations.
>> 2. the deep copy of config element is not implemented, that might be
>> more work than adding the support for --target to CLI commands.
> I don't know which is more work but if we keep default-config outside
> we'll need to do things like.... For create-domain, it will probably
> need to make it's own copy of default-config.xml for each domain.
why ? I thought in V2 we had 1 copy of this default-config.xml for all
domains (in lib/templates) Is that not the case ?
I guess that if there is one copy per domain, this is a very useless
feature !
> For CLI/GUI they would have another code path to write to a second
> file - customizing the default-config.xml template. As long as we're
> ok with that.
>
>>
>> as for the GUI, it we can make them switch to REST, they might still
>> be able to use set those default-config.xml
>>
>> so the picture is not that clean...
>>
>> On 4/6/2010 4:26 PM, Jennifer Chou wrote:
>>> Hi Jerome,
>>>
>>> In the admin iteam we were thinking it's better to keep
>>> default-config inside domain.xml (unless there is some difficulty
>>> with adding the 'copy config' code). Abhijit had raised a point we
>>> which we hadn't discussed last week. default-config is not just a
>>> template, but a customizable template via CLI/GUI.
>>> In v2.x we had the ability to customize the default-config using
>>> CLI/GUI ( Most of the commands have --target option and
>>> configuration name is a valid value for the target option.)
>>> So if we keep the default-config in domain.xml, we can take care of
>>> both
>>> 1) supporting customization of default-config via CLI/GUI
>>> 2) v2.x upgrade with a customized default-config
>>>
>>> What do you think?
>>>
>>> Jennifer
>>>
>>> On 4/7/2010 8:46 PM, Jerome Dochez wrote:
>>>> On 4/6/2010 11:44 AM, Jennifer Chou wrote:
>>>>> Hi Jerome,
>>>>>
>>>>> Thanks for adding the support. I haven't added it yet. I need to
>>>>> make some updates,
>>>> it does not need to be the final version to be added ;-)
>>>>> then I will add the default-config.xml to lib/templates. I'll let
>>>>> you know.
>>>>>
>>>> ok, thanks
>>>>> Thanks,
>>>>> Jennifer
>>>>>
>>>>> On 4/6/2010 6:48 PM, Jerome Dochez wrote:
>>>>>> Hi
>>>>>> I have added preliminary support for default-config.xml parsing
>>>>>> when create-cluster is called without a config-ref parameter.
>>>>>> So far, I am looking inside domains/domain/config directory for
>>>>>> the default-config.xml which is probably the wrong location but
>>>>>> we don't seem to have that default-config.xml anywhere (neither
>>>>>> in our distribs or workspace).
>>>>>>
>>>>>> Can someone take care of adding the default-config.xml to the
>>>>>> distribution and let me know of the file location, I can update
>>>>>> the code accordingly.
>>>>>>
>>>>>> thanks, Jerome
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>