+1
making too many packages encourages making things public when they
shouldn't be.
I'll change the cli package name as Bill suggested...
Sent from my iPhone
On Apr 2, 2010, at 4:10 PM, Bill Shannon <bill.shannon_at_oracle.com>
wrote:
> When you say "CLIs", what do you mean?
>
> If you mean the server-side implementations of CLI commands, the
> answer is no.
>
> If you mean client-side local asadmin CLI commands, the answer is
> they're
> in a different package.
>
> What do you mean?
>
> Unlike some people, I don't tend to create new packages at the drop
> of a hat. Just because you can think of a logical grouping of more
> than one class, doesn't mean you need a new package.
>
> So, if there's a few server-side classes that will work with the
> server-side admin commands, I'd just put them in the same package.
>
> If there's 30 such classes, I'd create a new package.
>
> And we can create subpackages of com.sun.enterprise.v3.admin.cluster
> even though there's also classes directly in
> com.sun.enterprise.v3.admin.cluster.
>
> Just my opinion...
>
>
> Vijay Ramachandran wrote on 04/ 2/10 03:59 PM:
>> On 4/2/2010 3:48 PM, Bill Shannon wrote:
>>> Sorry, been tied up in meetings...
>>>
>>> I suggested com.sun.enterprise.v3.admin.cluster for the server-side
>>> command implementations,
>>
>> Dont we need a "cli" (or similar) 'sub package' for CLIs under
>> com.sun.enterprise.v3.admin.cluster ?
>>
>> That way dynamic reconfig / command replication related classes can
>> go
>> under com.sun.enterprise.v3.admin.cluster.dynamicreconfig or
>> something
>> like that
>>
>> Vijay
>>
>>> because that paralleled the existing
>>> server-side commands in com.sun.enterprise.v3.admin.
>>>
>>> For the client-side CLI commands I've been using
>>> com.sun.enterprise.admin.cli.cluster for similar reasons.
>>>
>>> I'm sure we're going to need some common classes shared between
>>> client and server but I haven't thought about where they should
>>> exist. We probably need another module for them too.
>>>
>>>
>>> Byron Nevins wrote on 04/ 2/10 03:38 PM:
>>>> Based on Jennifer's interpretation of Bill's wishes -- the official
>>>> name for the clustering cli package is, drum roll,
>>>>
>>>> ======================
>>>> com.sun.enterprise.v3.admin.cluster.cli
>>>> ======================
>>>>
>>>>
>>>> Any objections? The longer we wait the bigger the hassle to
>>>> change it...
>>>>
>>>>
>>>>
>>>> On 4/2/2010 11:59 AM, Jennifer Chou wrote:
>>>>> Bill had mentioned this previously...
>>>>>
>>>>> Any server-side remote cluster commands should be in package
>>>>> com.sun.enterprise.v3.admin.cluster
>>>>>
>>>>> I don't know if we have any protocol when to use com.sun. or
>>>>> org.glassfish.
>>>>>
>>>>> On 4/2/2010 7:57 PM, Byron Nevins wrote:
>>>>>> [cluster:cli] org.glassfish.admin.cli.cluster
>>>>>>
>>>>>> I am using the above as a working name for the package.
>>>>>> Feedback? If
>>>>>> you have opinions -- please give them soon before I checkin and
>>>>>> make
>>>>>> it more of a hassle to undo :-)
>>>>>>
>>>>
>>>
>>>
>>> ---
>>> ------------------------------------------------------------------
>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>