admin@glassfish.java.net

Re: Final Review of create-domain man page

From: Bill Shannon <bill.shannon_at_sun.com>
Date: Wed, 21 Oct 2009 19:33:56 -0700

Dixie Pine wrote on 10/21/09 3:55 PM:
> On 10/20/09 02:18 PM, Sankar Neelakandan wrote:
>> Hi Dixie,
>> --adminport and --portbase are mutually exclusive options. It
>> should be described as
>> [--adminport 4848 | --portbase portbase] [--instanceport 8080]
> I looked at the command message and I see no attempt to indicate mutual
> exclusivity. It gets very complicated, especially when instanceport is
> factored in. So I added a sentence in each port option description to
> explain the mutual exclusivity.

The command metadata isn't rich enough to express this relationship between
options, so the code that automatically generates the usage message based
on the command metadata can't do any better. We could hardwire the usage
message, but that makes it more fragile as the command is changed.

> *BUG?* 4848 and 8080 should not be in the command message, but they
> are. They should be shown as <adminport> and <instanceport>
> replaceables. I changed the man page. Can the command message be fixed?

It's a feature. :-)

Seriously, people asked for the usage message to indicate the default
values of the options, where they're known, so that's what the code does.
If there's consensus that that should be removed, that's easy to do.

Let's see what people think. I created a poll...

http://sun.doodle.com/6t38vi48u5uyvpg4