On Apr 8, 2008, at 7:43 AM, Prashanth Abbagani wrote:
> This will be useful. But for boolean parameters, can we encourage
> the developers to declare the param as boolean type (as against
> String), and you implicitly validate the option value for (true or
> false).
>
right, I like the feature but not the example...
we should have
@Param(optional=true)
Boolean enabled
and let the system figure out the conversion (constructor with String
paramerter).
having said that, the acceptableValues is interesting for other
things, and could/ should be enhanced to support range :
like
@Param(acceptableValues="0..100")
Integer numberOfThreads;
Jerome
> Byron Nevins wrote:
>> I've implemented, but not checked in yet, support for validating
>> param values against an acceptable list of values.
>> This is immediately useful for boolean parameters -- we want
>> 'booleanOptionX=garbage' to be a hard error rather than just
>> silently setting it to false.
>>
>> Are there other use cases for "acceptableValues" in Remote Commands?
>>
>> E.g.
>>
>> before:
>> @Param(optional=true)
>> String enabled = Boolean.TRUE.toString();
>>
>> after:
>> @Param(optional=true, acceptableValues="true,false")
>> String enabled = Boolean.TRUE.toString();
>>
>> At injection time -- if the parameter has a value -- then it is
>> compared against the comma separated list of acceptable values.
>> If it does not match any of them -- an Exception is thrown before
>> the execute() method is called.
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>