In regard to your fix, how about modifying the private method to accept
FacesContext as a parameter? For example, similar to the
renderSelectedTab method below. I don't believe there is any performance
gain, but we already have the FacesContext available in encodeChildren.
private List renderSelectedTab(FacesContext context, ResponseWriter
writer...
Dan
Sean Comerford wrote:
> I've attached a list of the "gotchas" I came across building the 3 projects.
>
> Also, I have a simple 3 line fix to something (surprise surprise) I botched a
> long time ago - issue 488. Diffs follow - advise if there is some other
> specific way to send reviews.
>
> Now when do I get paid? I'm hungry Dick and we have an agreement!
>
> ----------------------------
>
> RCS file:
> /cvs/woodstock/webui/src/runtime/com/sun/webui/jsf/renderkit/html/TabSetRenderer.java,v
> retrieving revision 1.1
> diff -u -w -b -r1.1 TabSetRenderer.java
> --- TabSetRenderer.java 16 Feb 2007 01:44:40 -0000 1.1
> +++ TabSetRenderer.java 31 Jul 2007 23:53:21 -0000
> @@ -226,6 +226,11 @@
>
> writer.startElement("div", tabSet);
>
> + String clientId =
> tabSet.getClientId(FacesContext.getCurrentInstance());
> + if (clientId != null) {
> + writer.writeAttribute("id", clientId, null);
> + }
> +
> if (style != null) {
> writer.writeAttribute("style", style, null); // NOI18N
> }
>
>
>
> later,
> Sean
> http://seanc.us
>
> ------------------------------------------------------------------------
>
> 1. The "built it yourself" doc states (apparently incorrectly) that the project
> build order is themes, webui, example - I gather it should webui, themes,
> example.
>
> 1a. I had to open each project individually (doc says they will all open when
> example is opened - false) and then build them in the order above.
>
> 2. The build scripts don't account for the fact that the various paths of evil
> Windoze developers like myself may contrain spaces. So if (like me) you
> initially checked out the code to the default WinCVS location (c:\program
> files\cvs\cvs_wd\..) you = screwed in terms of building the various projects.
> You can fix the build script but it's just easier to note that you should
> check woodstock out to a dir with no spaces in it.
>
> 3. My java.home property is set but for some reason I had to modify line 86 of
> webui's build.xml to explicitly point to my java home dir (i.e. change it to
> value="/usr/java" else="/usr/java") when it runs the apt command
>
> 4. Scheduler attempted to import import sun.text.resources.LocaleData - not sure
> where this is but class can't be found and isn't used anyway so commented out
> import
>
> General question - this build is kinda slow... I'm too lazy to look at it but
> is there by any chance an easy way to tell the script NOT to build the
> annotations and javadoc every time? I change 3 lines of code in one file and it
> takes 2 minutes to rebuild webui and I'm on a pretty decent dual core
> Pentium with 2 gig of ram.
>
>
>
>
>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_woodstock.dev.java.net
> For additional commands, e-mail: dev-help_at_woodstock.dev.java.net
>