On 02/14/2013 10:10 AM, Mark Thomas wrote:
> On 13/02/2013 23:16, Shing Wai Chan wrote:
>> I am looking at
>> http://java.net/jira/browse/SERVLET_SPEC-54
>> Javadoc inconsistent for HttpServletRequest#changeSessionId()
>>
>> I have took a look at JDK 7 API. All except two of changeXXX API return
>> void.
>> The only exceptions are java.lang.invoke.MethodType#changeParameterType,
>> changeReturnType
>> where the #changeXXX also do a "find" action there.
>>
>> Should we return void for #changeSessionId for consistent?
> I think not. As Alex pointed out early on the discussion about this
> feature, when the ID is changed the caller will almost certainly want to
> know what the new ID is so it makes sense to return it.
+1
Rémy