users@servlet-spec.java.net

[servlet-spec users] [jsr340-experts] Re: About SERVLET_SPEC-54

From: Mark Thomas <markt_at_apache.org>
Date: Thu, 14 Feb 2013 09:10:11 +0000

On 13/02/2013 23:16, Shing Wai Chan wrote:
> I am looking at
> http://java.net/jira/browse/SERVLET_SPEC-54
> Javadoc inconsistent for HttpServletRequest#changeSessionId()
>
> I have took a look at JDK 7 API. All except two of changeXXX API return
> void.
> The only exceptions are java.lang.invoke.MethodType#changeParameterType,
> changeReturnType
> where the #changeXXX also do a "find" action there.
>
> Should we return void for #changeSessionId for consistent?

I think not. As Alex pointed out early on the discussion about this
feature, when the ID is changed the caller will almost certainly want to
know what the new ID is so it makes sense to return it.

Mark