Hi,
Please find below the results of my review of the spec document. I still
need to look through the Javadoc. I'll send another mail if I find
anything there.
I've have been mostly focussed on the changes although there are a
couple of additional things I happened to spot as I worked through the
document.
Most of them are trivial formatting / typo issues.
Finally, there look to be a handful of currently open issues asking for
clarification or minor additions that we could address in time for the
final version.
Mark
Preface references RFC 2965
The vast majority of user agents never implemented this spec.
Historically, the Servlet API is based on RFC 2109. We should be
referencing RFC 6265. RFC 6265 is more restrictive than RFC 2109 in a
number of areas. We need to update the API to define behaviour if a
value that does not comply with RFC 6265 is passed. My initial thoughts
are throw an IllegalArgumentException. See SERVLET_SPEC-37.
Section 2.3.3.3 Page 2-16
s/complete/dispatch/ in the first sentence of the modified text.
Section 2.3.3.3 Page 2-17
complete isn't formatted as code in the first sentence of the modified text.
Section 3.12 Page 3-31
See discussion on list for updated text.
Section 5.6 Page 5-50
Possible clarification in the inserted text:
"... explicitly set the default encoding ..."
Section 6.2.4 Page 6-58
s/Multipe/Multiple/g
Section 7.5 Page 7-66
s/seesion/session/
Section 9.3.1 Page 9-101
I thought we agreed to name the new attribute
javax.servlet.include.servlet_mapping
to align with the associated methods and to avoid possible future conflicts
Also for forward and async attributes
Section 10.7.1 Page 10-11
Since Servlet 4 has a minimum of Java 8, this should probably link to
the Java 8 version of these docs rather than the Java 7 version.
Section 14.5.x
The examples should reference Servlet 4.0 XSD