jsr369-experts@servlet-spec.java.net

[jsr369-experts] Re: 4.0.0-b01 API review

From: Edward Burns <edward.burns_at_oracle.com>
Date: Mon, 12 Oct 2015 11:32:36 -0700

>>>>> On Fri, 9 Oct 2015 22:52:44 +0100, Mark Thomas <markt_at_apache.org> said:

MT> I've been comparing Tomcat's 4.0.0-b01 implementation with the RI and I
MT> found a couple of places where we could simplify things (I'm always in
MT> favour of deleting code if possible).

MT> Both instances are in GenericFilter
MT> - NO-OP destroy() method is unnecessary due to default
MT> implementation in Filter. Should be removed.
MT> - abstract doFilter() method is unnecessary since
MT> GenericFilter is abstract. Should be removed.

I've fixed this. Thanks,

Ed

-- 
| edward.burns_at_oracle.com | office: +1 407 458 0017
| 19 Business days til JavaOne 2015
| 34 Business days til DOAG 2015