Looks good to me. Thanks for getting this work done amongst many competing priorities.
-------- Original message --------From: Lukas Jungmann <lukas.jungmann_at_oracle.com> Date: 4/26/17 6:02 AM (GMT-05:00) To: users_at_jpa-spec.java.net Subject: [jpa-spec users] JPA_SPEC-115: Add @Repeatable(containerClass.class)
Hi,
in order to address adoption of @Repeatable in JPA APIs[1]
following is the complete list of changed annotations:
javax.persistence.AssociationOverride
javax.persistence.AttributeOverride
javax.persistence.Convert
javax.persistence.JoinColumn
javax.persistence.MapKeyJoinColumn
javax.persistence.NamedEntityGraph
javax.persistence.NamedNativeQuery
javax.persistence.NamedQuery
javax.persistence.NamedStoredProcedureQuery
javax.persistence.PersistenceContext
javax.persistence.PersistenceUnit
javax.persistence.PrimaryKeyJoinColumn
javax.persistence.SecondaryTable
javax.persistence.SqlResultSetMapping
I believe that this is list is clear, non-controversial since all
of these annotations do have their corresponding container
annotation and therefore this change can be included in JPA 2.2
MR.
Two other candidates for adding @Repeatable are:
javax.persistence.SequenceGenerator
javax.persistence.TableGenerator
as both may be specified either on the entity class or on the
primary key field or property, therefore there might be multiple
occurrences within one class. But in this case there are currently
no related container annotations.
I see too options:
do not change these annotations
add javax.persistence.SequenceGenerators and
javax.persistence.TableGenerators container annotations and add
@Repeatable to Sequence/TableGenerator as well
I'd like to propose going with option 2 - or does anyone see why
it should not be done this way?
Thank you,
--lukas
[1]:
https://java.net/jira/browse/JPA_SPEC-115