Hi Erik,
On Tue, Mar 22, 2011 at 9:36 PM, <eirik.lygre_at_gmail.com> wrote:
>> When you're ready, please let me know, I'd like to review the poms. I
>> can also perform the releases into the central Maven repo.
>
> So i just uploaded the fluent-api and value-constructor source code.
> It's pretty much the same as found in the old repositories, with a
> couple of changes:
>
> * Package and class names was aligned with what I found in the basics
> project
>
> I'm not a regular maven user, so I'm pretty sure the pom is not very
> good. If you don't mind, I'd be happy if you could pick one of the two
> poms and apply some best practice thinking to it; I will then copy this
> onto the other.
>
> Also, I don't know what to do with plugin versioning, so I set the
> number to 2.2 (which is higher than the last fluent-api plugin I know
> of, which was named 2.1.8).
>
> Any thoughts?
I've reviewed what you've committed. The poms were almost perfect!
I've made few minor corrections:
* I've added few elements to fulfill the requirements here:
https://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+Usage+Guide#SonatypeOSSMavenRepositoryUsageGuide-5.Prerequisites
* Parent set to
<parent>
<groupId>org.sonatype.oss</groupId>
<artifactId>oss-parent</artifactId>
<version>7</version>
</parent>
* JAXB-XJC version set to 2.1.13. Scope set to "provided" - it is
important, otherwise the plugin will be transitively bringing XJC with
it.
* I've set the version to 3.0 in both plugins.
* I've added the original developers as "developers".
* Would you maybe list yourself as "contributor"?
So from my point of view the plugins can be released. Would you please
re-test them and let me know if everything's ok? I'll perform the
releases then.
How about wiki-documentation?
Bye,
/lexi