Hi Lenny,
The correct list is issues_at_javaserverfaces.java.net
Thanks!
Kind regards,
Manfred Riem
On 3/2/16, 12:07 PM, Lenny Primak wrote:
> The email to issues_at_mojarra.java.net <mailto:issues_at_mojarra.java.net> 
> was rejected by the list server.
> As far as testing, the code involved isn’t tested by an existing test 
> suite,
> and unfortunately, will require more extensive refactoring to write a 
> new test.
> I don’t think it’s worth doing it at this point, and it may break more 
> than it tests / fixes.
> I am not against testing BTW, and a big proponent of TDD (and utilize 
> it in my own projects)
>
>> On Mar 2, 2016, at 12:01 PM, Lenny Primak <lprimak_at_hope.nyc.ny.us 
>> <mailto:lprimak_at_hope.nyc.ny.us>> wrote:
>>
>> Hi Arjan,
>>
>> I have submitted multiple patches for Mojarra in the past that were 
>> accepted.
>> I have signed oracle OCA a while ago and am “on the list”: 
>> http://www.oracle.com/technetwork/community/oca-486395.html
>> Also, I have published the diff-patch in the issue and issues and 
>> that was enough in the past.
>> I have, however sent the diff-patch to the below email address as well.
>>
>>> On Mar 2, 2016, at 7:47 AM, arjan tijms <arjan.tijms_at_gmail.com 
>>> <mailto:arjan.tijms_at_gmail.com>> wrote:
>>>
>>> Hi Lenny,
>>>
>>> Thanks for the patch. I quickly looked at it and at first sight it 
>>> looks okay. Because of legal and technical reasons we cannot accept 
>>> a PR through github at the moment. The path to use is sending the 
>>> patch to issues_at_mojarra.java.net <mailto:issues_at_mojarra.java.net>. 
>>> Only exception is if you signed the Oracle OCA before.
>>>
>>> The GitHub repo where you're doing commits now against is a strict 
>>> read-only mirror. I'd love to see another "upstream" repo set up 
>>> which can technically take PRs, but then there's still the legal 
>>> matter that for the moment requires mailing the patch.
>>>
>>> @Manfred; any way the disclaimer for contributions can be extended 
>>> to GitHub PRs next to sending mail to issues_at_mojarra.java.net 
>>> <mailto:issues_at_mojarra.java.net>? Would make everyone's live a LOT 
>>> easier.
>>>
>>> Additionally, before the patch can be committed downstream a test 
>>> for it is needed as well. Can you look into that?
>>>
>>> Kind regards,
>>> Arjan
>>>
>>>
>>>
>>>
>>>
>>> On Wed, Mar 2, 2016 at 1:50 AM, Lenny Primak <lprimak_at_hope.nyc.ny.us 
>>> <mailto:lprimak_at_hope.nyc.ny.us>> wrote:
>>>
>>>     I’ve got very simple diff / merge/ pull request made for this bug:
>>>     https://java.net/jira/browse/JAVASERVERFACES-4107
>>>
>>>>     On Mar 1, 2016, at 5:36 PM, Lenny Primak
>>>>     <lprimak_at_hope.nyc.ny.us <mailto:lprimak_at_hope.nyc.ny.us>> wrote:
>>>>
>>>>     Can we get one more bug into Milestone 5?
>>>>     I just found one and I’d like to get that into M5
>>>>     https://java.net/jira/browse/JAVASERVERFACES-4107
>>>>     Thank you!
>>>>
>>>>
>>>>>     On Feb 27, 2016, at 6:16 PM, Lenny Primak
>>>>>     <lprimak_at_hope.nyc.ny.us <mailto:lprimak_at_hope.nyc.ny.us>> wrote:
>>>>>
>>>>>     I suppose, but it’s *much* easier to get the milestones, since
>>>>>     they are published on maven central,
>>>>>     but the snapshots aren’t.
>>>>>
>>>>>>     On Feb 27, 2016, at 5:23 PM, arjan tijms
>>>>>>     <arjan.tijms_at_gmail.com <mailto:arjan.tijms_at_gmail.com>> wrote:
>>>>>>
>>>>>>     Hi,
>>>>>>
>>>>>>     On Sat, Feb 27, 2016 at 7:24 PM, Lenny Primak
>>>>>>     <lprimak_at_hope.nyc.ny.us <mailto:lprimak_at_hope.nyc.ny.us>> wrote:
>>>>>>
>>>>>>         I guess Manfred & Ed are working on MVC and HTTP/2
>>>>>>         respectively?
>>>>>>
>>>>>>
>>>>>>     To the best of my knowledge Manfred is not really working on
>>>>>>     MVC either, but it's a question he can best answer himself.
>>>>>>
>>>>>>         I would still like to see a m05 release, specifically for
>>>>>>         this:
>>>>>>         https://java.net/jira/browse/JAVASERVERFACES-4077
>>>>>>
>>>>>>
>>>>>>     That's indeed one of the few commits that went in since m04.
>>>>>>
>>>>>>     But since you are already running milestones, isn't it just
>>>>>>     as easy for you to just grab a snapshot build? For an m05
>>>>>>     release we may have to ask Zhijun who can do releases as well.
>>>>>>
>>>>>>     Kind regards,
>>>>>>     Arjan Tijms
>>>>>>
>>>>>>
>>>>>>>         On Feb 27, 2016, at 7:21 AM, arjan tijms
>>>>>>>         <arjan.tijms_at_gmail.com <mailto:arjan.tijms_at_gmail.com>>
>>>>>>>         wrote:
>>>>>>>
>>>>>>>         Hi Lenny,
>>>>>>>
>>>>>>>         Sorry for not replying to this before. We currently have
>>>>>>>         a bit of a resource problem when it comes to JSF
>>>>>>>         development. I personally am spending the little time I
>>>>>>>         have mostly on work for JSR 375, while Bauke is still
>>>>>>>         working on the f:websocket patch (it's severely more
>>>>>>>         difficult and involving than initially anticipated).
>>>>>>>
>>>>>>>         I can't speak directly for Manfred and Ed, but it seems
>>>>>>>         their level of commits to Mojarra is currently not as
>>>>>>>         big as it once was.
>>>>>>>
>>>>>>>         Long story short; there's relatively little to release
>>>>>>>         at this moment for a Milestone 5. I'm a bit worried
>>>>>>>         about this too to be honest.
>>>>>>>
>>>>>>>         Kind regards,
>>>>>>>         Arjan Tijms
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>         On Tue, Feb 16, 2016 at 12:44 AM, Lenny Primak
>>>>>>>         <lprimak_at_hope.nyc.ny.us <mailto:lprimak_at_hope.nyc.ny.us>>
>>>>>>>         wrote:
>>>>>>>
>>>>>>>             It says in Jira it’s should be released on January 5th,
>>>>>>>             It’s now February 15th, and still no Milestone 5.
>>>>>>>             Any idea / estimate when M05 will be released?
>>>>>>>
>>>>>>>             Thank you
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>>
>