dev@javaserverfaces.java.net

Re: Zhijun: Mojarra 2.3 AdminGUIIT test reemove _at_Ignore

From: zhijun Ren <ren.zhijun_at_oracle.com>
Date: Tue, 29 Sep 2015 17:31:18 +0800

Hi Ed,

I used glassfish 4.1 to do the test today, I found:

1. The issue is related to the jsf, without patch jsf, there is no
problem, the 'localhost:4848' was visible. but if patched with latest
jsf(2.3.0-m03-snapshot), the problem happened. I will call them correct
and wrong cases respectively in the following description;

2. I debuged with glassfish's code, found the following codes run
differently in the correct and wrong cases. class
org.glassfish.admingui.common.handlers.PluginHandlers's
includeFirstIntegrationPoint() method:

/ @Handler(id="includeFirstIntegrationPoint",
     input={
         @HandlerInput(name="type", type=String.class, required=true),
         @HandlerInput(name="root", type=UIComponent.class,
required=false)})
     public static void includeFirstIntegrationPoint(HandlerContext
handlerCtx) throws java.io.IOException {
     // Get the input
     String type = (String) handlerCtx.getInputValue("type");
UIComponent root = (UIComponent) handlerCtx.getInputValue("root");/

in wrong case, when the type is "org.glassfish.admingui:loginform", the
root is null. but in correct case, the root is not null.

I will do further investigation tomorrow, but it will be helpful if
there is someone from Glassfish team(Admin GUI/Console) can help to
check the above code.

BR,
Zhijun


On 9/29/15, 5:12, Edward Burns wrote:
>>>>>> On Mon, 28 Sep 2015 12:52:57 -0700, Edward Burns<edward.burns_at_oracle.com> said:
> EB> Hello Zhijun,
> EB> On September 8th Manfred marked the AdminGUIIT test to be @Ignore due to
> EB> a change in the Admin GUI of the GlassFish trunk. Manfred explained it
> EB> to me as a matter of the AdminGUI changing its password policy: they
> EB> used to require a password and now they do not.
>
> EB> I sat down today to try to return this very important test to being run
> EB> but discovered it was more than just a simple password change.
>
> EB> When I downloaded the latest GlassFish trunk nightly [1] and overwrote
> EB> the glassfish4/glassfish/modules/javax.faces.jar with a freshly built
> EB> 2.3 trunk I see an exception and a blank page when I visit the adminGUI
> EB> at http://localhost:4848/. I don't see this exception when I use the
> EB> stock Mojarra included in the GlassFish nightly zip (2.2.12).
>
> EB> Here's the stack trace:
>
> Manfred suggested I take the 2.3.0-m04-SNAPSHOT (that is, HEAD of
> master) and try it on GlassFish 4.1. I did so and observe the same
> problem.
>
> It's definitely a regression. Zhijun, please give this high priority
> because I'd like to be able to tell people to try Mojarra 2.3.0-m04 to
> evaluate the JSF 2.3 EDR.
>
> Thanks,
>
> Ed
>