Re: Please do the code review for jsf bugs:3574,3694, 3695

From: zhijun Ren <>
Date: Tue, 03 Feb 2015 14:47:49 +0800

Hi Ed and Manfred,

For the convenience of the remaining flow issues, I have committed the
code into trunk and set #3694 and #3695 as resolved.

/rzhijun-mac:trunk zhijun$ svn commit --file
changebundle_zhijun_for_3695and3694and3574_on150129.txt --username
Transmitting file data ...
Committed revision 14304./

I will send out the code review request for #3475 and #3476 soon.

Let 3574 be opened for porting back to 2.2.8, do you agree?


On 1/31/15, 2:35, zhijun Ren wrote:
> Ed, just a reminder in case of that you miss the mail.
> On 1/29/15, 14:30, zhijun Ren wrote:
>> All Hudson tests against WLS also have been done locally without any
>> of them failed, thanks.
>> On 1/29/15, 13:50, zhijun Ren wrote:
>>> Hi Ed and Manfred,
>>> Please help to do the review for the three bugs, change bundle
>>> attached here for your convenience.
>>> Note that besides fixing the bugs, I have run all Hudson tests
>>> against GF and didn't fail any of them.
>>> During the working of these faces flow bugs, I really think the
>>> current design is not good, e.g., code duplication, implicit
>>> recursive call, many flag variables and if statements, bad
>>> readability, etc.. , looking forward to refactor by a state machine.
>>> BR,
>>> Zhijun