Re: Please do the code review for jsf bugs:3574,3694, 3695

From: zhijun Ren <>
Date: Sat, 31 Jan 2015 02:35:50 +0800

Ed, just a reminder in case of that you miss the mail.

On 1/29/15, 14:30, zhijun Ren wrote:
> All Hudson tests against WLS also have been done locally without any
> of them failed, thanks.
> On 1/29/15, 13:50, zhijun Ren wrote:
>> Hi Ed and Manfred,
>> Please help to do the review for the three bugs, change bundle
>> attached here for your convenience.
>> Note that besides fixing the bugs, I have run all Hudson tests
>> against GF and didn't fail any of them.
>> During the working of these faces flow bugs, I really think the
>> current design is not good, e.g., code duplication, implicit
>> recursive call, many flag variables and if statements, bad
>> readability, etc.. , looking forward to refactor by a state machine.
>> BR,
>> Zhijun