dev@javaserverfaces.java.net

Re: seeking review 1663

From: Jason Lee <jason_at_steeplesoft.com>
Date: Thu, 26 Aug 2010 20:19:53 -0500

  +1

On 8/26/10 8:19 PM, Ed Burns wrote:
>>>>>> On Thu, 26 Aug 2010 19:16:02 -0500, Jason Lee<jason_at_steeplesoft.com> said:
> JL> I think checking for a parent of UIViewRoot, while helpful, isn't
> JL> sufficient. I think you hit on the issue with your UIPanel question. I
> JL> think, then, you'd almost have to walk up the tree until you find either
> JL> UIViewRoot or a UIForm. The value fro
> JL> com.sun.faces.MISSING_FORM_FOR_BUTTON should be updated to reflect that
> JL> the immediate parent need not be the UIForm.
>
> JL> There's also no check to make sure the user is in development mode.
> JL> This is certain to be expensive, so this shouldn't be done for a
> JL> production app (which the issue's initial comment suggests).
>
> I would like it to be the case that if you have any ui components that
> implement ActionSource, ActionSource2, or EditableValueHolder that are
> not enclosed within a UIForm, then you get the error message.
>
> Furthermore, I would like this feature to take effect only if
> ProjectStage == Development. If ProjectStage is not Development, there
> must be no runtime performance penalty of any kind, other than checking
> the ProjectStage, to support this feature.
>
> Ed
>


-- 
Jason Lee
Senior Member of Technical Staff at Oracle
http://blogs.steeplesoft.com