From: Ed Burns <edward.burns_at_oracle.com>
Date: Thu, 22 Jul 2010 13:41:41 -0700

>>>>> On Wed, 21 Jul 2010 15:04:18 -0700, Sheetal Vartak <sheetal.vartak_at_oracle.com> said:

SV> Here's a code review request for spec issue 733. I finally managed to get my hosting machine setup for this issue since I needed JDK 5 (which my macbook pro's Snow Leopard does not support ).
SV> The changed files are :
SV> M jsf-api/src/main/java/javax/faces/context/ExternalContext.java
SV> M jsf-ri/test/com/sun/faces/context/TestExternalContextImpl.java
SV> M jsf-ri/src/main/java/com/sun/faces/context/ExternalContextImpl.java
SV> M lib/jsf-extensions-test-time.jar

This looks fine, but I need to see the mods for the
jsf-extensions-test-time code as well, and also you need to make sure
that you build jsf-extensions-test-time.jar using Java SE 5.

Thanks,

Ed

-- 
| edburns_at_oracle.com | office: +1 407 458 0017
| homepage:          | http://ridingthecrest.com/
| 16 work days until JSF 2.1 Milestone 2