On 7/22/10 3:06 PM, Ed Burns wrote:
> https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1709
>
> Please edit build.properties.glassfish to indicate that V3.1 is now a
> valid value for container.name. There are comments in there for v2 and
> v3, put it in there.
>
ack.
> Should config.properties.patch really be committed?
>
probably not - but I'll verify
> jsf-ri/build-tests.xml, why are you removing TestApplicationImpl_Config
> when you add TestInjection?
>
good catch - I'll fix that.
> Index:
> jsf-ri/systest-per-webapp/injection/src/java/com/sun/faces/systest/Foo.java,
> do we need this class?
>
Yes - that's the class being injected for the test case.
> Index: jsf-ri/systest-per-webapp/injection/web/WEB-INF/web.xml
>
> If you're going to add a web.xml for a 3.1 only app, set the XSD stuff to Servlet 3.0.
>
> I don't like the way you're doing the exclusion business. Can you skip
> checking in jsf-ri/systest-per- webapp/build.xml and
> jsf-ri/systest-per-webapp/build-tests.xml but check in everything else.
>
> Once you check it in, I'll suggest some diffs that you can apply and
> check in once you consent and modify as necessary.
>
> Ed
>
>
--
roger.kitain_at_oracle.com
https://twitter.com/rogerk09
http://www.java.net/blogs/rogerk