dev@javaserverfaces.java.net

Review for 1709

From: Ed Burns <edward.burns_at_oracle.com>
Date: Thu, 22 Jul 2010 12:06:12 -0700

https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1709

Please edit build.properties.glassfish to indicate that V3.1 is now a
valid value for container.name. There are comments in there for v2 and
v3, put it in there.

Should config.properties.patch really be committed?

jsf-ri/build-tests.xml, why are you removing TestApplicationImpl_Config
when you add TestInjection?

Index:
jsf-ri/systest-per-webapp/injection/src/java/com/sun/faces/systest/Foo.java,
do we need this class?

Index: jsf-ri/systest-per-webapp/injection/web/WEB-INF/web.xml

If you're going to add a web.xml for a 3.1 only app, set the XSD stuff to Servlet 3.0.

I don't like the way you're doing the exclusion business. Can you skip
checking in jsf-ri/systest-per- webapp/build.xml and
jsf-ri/systest-per-webapp/build-tests.xml but check in everything else.

Once you check it in, I'll suggest some diffs that you can apply and
check in once you consent and modify as necessary.

Ed

-- 
| edburns_at_oracle.com | office: +1 407 458 0017
| homepage:          | http://ridingthecrest.com/
| 16 work days until JSF 2.1 Milestone 2