dev@javaserverfaces.java.net

Re: Devtest code Review

From: Sheetal Vartak <sheetal.vartak_at_oracle.com>
Date: Wed, 7 Jul 2010 12:24:53 -0700

Hi Ed,
Thanks for the review. I already have the page.asText() check after the button.click() is called. Will incorporate the page.asXml() to see if it contains the string javax.faces.ViewState.
Will repost for a review.

Thanks
Sheetal
On Jul 7, 2010, at 11:30 AM, Edward Burns wrote:

> On 7/6/10 16:43 , Sheetal Vartak wrote:
>> Hi Ed/Roger,
>>
>> I am sending my devtest for a review before I check it in.
>
> Hello Sheetal,
>
> Looks pretty good, but needs a little bit more to actually catch feature regressions.
>
> Your no-web-xml/src/java/com/sun/faces/systest/NoWebXMLTestCase.java needs a little more depth. For each of the three pages, I want you to find the button, click it, and then on the resultant page, verify page.asText() contains the correct message, and page.asXml() contains the string javax.faces.ViewState.
>
> Please make thses changes and repost the request for review.
>
> Also, you need only send it to dev_at_javaserverfaces.
>
> Thanks,
>
> Ed
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>