dev@javaserverfaces.java.net

Re: [mojarra trunk] no visit for UIColumn(s) in UIData.visitTree(VisitContext, VisitCallback) ?

From: Martin Kočí <Martin.Koci_at_aura.cz>
Date: Wed, 25 Mar 2009 23:03:59 +0100

Ryan Lubke píše v St 25. 03. 2009 v 13:34 -0700:
> On 3/25/09 1:42 PM, Martin Kočí wrote:
> > Hi,
> >
> > I'm trying latest mojarra from SVN, but there there is a state saving
> > issue with UIColumn (state is not saved). I think the problem in
> > UIData.visitTree, because visit does not process direct children of
> > UIData - UIColumns:
> >
> > if ((result == VisitResult.ACCEPT)&& doVisitChildren(context)) {
> >
> > // First visit facets
> > if (visitFacets(context, callback))
> > return true;
> >
> > // Next column facets
> > if (visitColumnFacets(context, callback))
> > return true;
> >
> > // And finally, visit rows
> > if (visitRows(context, callback))
> > return true;
> > }
> >
> > Only UIData facets, UIColumns facets and rows are visited.
> >
> > After changing method visitColumnFacets to visitColumnAndColumnFacets
> > (and it's implementation) it is working. Is it desired behaviour or a
> > bug?
> >
> Sounds like a bug. Would you mind opening an issue so we can track this?

https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1056

Btw. there is (in trunk) over 90 usages of <h:column> in JPSs, but only
very few of them has attributes (<10)

>
> Thanks,
> -rl
> > Regards,
> >
> > Martin
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
> > For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
> For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net
>
>