r=kenpaulsen
Hi Ryan,
Here are my suggestions:
On LOGGER calls where you pass in more than a String (i.e. you make a
method call or concatenate variables), put an if
(LOGGER.isLoggable(Level....)) {...} around them.
If appropriate, check for the scopes individually instead of all at
once. This is regarding this code:
+ Map<String,Object> requestMap = ec.getRequestMap();
+ Map<String,Object> sessionMap = ec.getSessionMap();
+ Map<String,Object> appMap = ec.getApplicationMap();
+ if (requestMap != null
+ && sessionMap != null
+ && appMap != null) {
+ if (requestMap.containsKey(identifier)) {
+ return Scope.REQUEST;
+ } else if (sessionMap.containsKey(identifier)) {
+ return Scope.SESSION;
+ } else if (appMap.containsKey(identifier)) {
+ return Scope.APPLICATION;
+ }
....
Looks like you already fixed both of those per our IRC discussion.
Thanks,
Ken
Ryan Lubke wrote:
> Change bundle and new source files are attached.
>
> Looking for any/all feedback ;)
>
>