Re: [REVIEW] Add logic to jsf-api create.standard.xml task to validate the generated document

From: Ed Burns <Ed.Burns_at_Sun.COM>
Date: Thu, 11 Nov 2004 12:29:13 -0800

>>>>> On Thu, 11 Nov 2004 11:49:47 -0500, Ryan Lubke <Ryan.Lubke_at_Sun.COM> said:

RL> The target will now fail if the generated document isn't valid.

Very nice. This will go a long way towards keeping the tree green.

RL> SECTION: Modified Files
RL> -----------------------------------
RL> M jsf-api/build.xml
RL> - Use custom ValidateTask to perform schema validation of the
RL> generated standard-html-renderkit.xml

RL> A jsf-tools/src/com/sun/faces/ant/
RL> - Simple task to perform schema validation of
RL> standard-html-renderkit.xml

It's nice that you found my existing task a roomate.

RL> ------------------------------------
RL> Index: build.xml
RL> ===================================================================
RL> RCS file: /cvs/javaserverfaces-sources/jsf-api/build.xml,v
RL> retrieving revision 1.136
RL> diff -u -r1.136 build.xml
RL> --- build.xml 8 Nov 2004 20:15:57 -0000 1.136
RL> +++ build.xml 11 Nov 2004 16:46:24 -0000
RL> @@ -732,6 +732,16 @@
RL> </replacevalue>
RL> </replace>
RL> <delete file="${basedir}/doc/standard-html-renderkit-impl.xml"/>
RL> +
RL> + <ant dir="${jsf-tools.dir}" target="tools" inheritAll="false"/>
RL> +

I'd like to at least see a PENDING comment that states that this target
shouldn't even be invoked if there is no need to invoke it. Perhaps we
could use uptodate for this.

You don't have to fix it now, though.



|  | {home: 407 294 2468, office: 408 884 9519 OR x31640}
| homepage:         |
| aim: edburns0sunw | iim:
To unsubscribe, e-mail:
For additional commands, e-mail: