dev@javaserverfaces.java.net

Re: Seeking Review: 8-ViewLifecycle

From: Ed Burns <Ed.Burns_at_Sun.COM>
Date: Thu, 11 Nov 2004 09:58:59 -0800

>>>>> On Thu, 11 Nov 2004 12:45:00 -0500, Roger Kitain <Roger.Kitain_at_Sun.COM> said:

RK> Just a few comments... (inline, of course)..
RK> also, take into accout Adam's Comments.

>> + private MethodBinding beforePhase = null;
>> + private MethodBinding afterPhase = null;
>>
RK> make these "beforePhaseListener"/"afterPhaseListener"?

>> +
>> + /**
>> + * @return the {_at_link MethodBinding} that will be invoked before
>> + * this view is rendered.
>> + *
>> + */
>> +
>> + public MethodBinding getBeforePhaseListener() {
>> + return beforePhase;
>> + }
>>
RK> make this "return beforePhaseListener"
RK> similar changes below

When speaking about a JavaBeans property, the ivar name is irrelevant.
The external contract is formed only by the getter and setter method
names.

Thanks,

Ed

-- 
| ed.burns_at_sun.com  | {home: 407 294 2468, office: 408 884 9519 OR x31640}
| homepage:         | http://javaweb.sfbay.sun.com/~edburns/
| aim: edburns0sunw | iim: ed.burns_at_sun.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net