Found by customer:
https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=21
"border" attribute should not be rendered on "input" html elements
M src/com/sun/faces/renderkit/html_basic/SelectManyCheckboxListRenderer.java
- include "border" as an "excluded" pass through attribute
M web/test/RenderResponse_correct
- new golden file
M web/test/TestRenderResponsePhase.jsp
- added "border" attribute for selectManyCheckbox component..
Index: SelectManyCheckboxListRenderer.java
===================================================================
RCS file:
/cvs/javaserverfaces-sources/jsf-ri/src/com/sun/faces/renderkit/html_basic/SelectManyCheckboxListRenderer.java,v
retrieving revision 1.36
diff -u -r1.36 SelectManyCheckboxListRenderer.java
--- SelectManyCheckboxListRenderer.java 26 Apr 2004 16:37:38 -0000 1.36
+++ SelectManyCheckboxListRenderer.java 27 Jul 2004 18:23:54 -0000
@@ -227,7 +227,7 @@
// items in the list except styleClass and style which are
rendered as
// attributes of outer most table.
Util.renderPassThruAttributes(writer, component,
- new String[]{"style"});
+ new String[]{"style", "border"});
Util.renderBooleanPassThruAttributes(writer, component);
String itemLabel = curItem.getLabel();
Index: TestRenderResponsePhase.jsp
===================================================================
RCS file:
/cvs/javaserverfaces-sources/jsf-ri/web/test/TestRenderResponsePhase.jsp,v
retrieving revision 1.80
diff -u -r1.80 TestRenderResponsePhase.jsp
--- TestRenderResponsePhase.jsp 12 May 2004 01:33:00 -0000 1.80
+++ TestRenderResponsePhase.jsp 27 Jul 2004 18:24:19 -0000
@@ -622,7 +622,7 @@
</tr>
<tr>
- <TD><h:selectManyCheckbox
id="ManyApples3"
+ <TD><h:selectManyCheckbox
id="ManyApples3" border="1"
tabindex="3"
disabledClass="disabledClass" style="someStyle"
styleClass="styleClass"
enabledClass="enabledClass" accesskey="A">>
<f:selectItem
itemValue="0" itemLabel="zero" itemDisabled="true" />
Index: RenderResponse_correct
===================================================================
RCS file:
/cvs/javaserverfaces-sources/jsf-ri/web/test/RenderResponse_correct,v
retrieving revision 1.106
diff -u -r1.106 RenderResponse_correct
--- RenderResponse_correct 11 Jun 2004 20:14:56 -0000 1.106
+++ RenderResponse_correct 27 Jul 2004 18:25:01 -0000
@@ -15,7 +15,7 @@
-<form id="basicForm" method="post"
action="/test/faces/TestRenderResponsePhase.jsp;jsessionid=D89943C1230B2E4CF4CF06F45B16624B"
class="formClass" accept-charset="some-charset" accept="html,wml"
enctype="application/x-www-form-urlencoded" title="basicForm">
+<form id="basicForm" method="post"
action="/test/faces/TestRenderResponsePhase.jsp;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"
class="formClass" accept-charset="some-charset" accept="html,wml"
enctype="application/x-www-form-urlencoded" title="basicForm">
<TABLE BORDER="1">
@@ -130,12 +130,12 @@
- <a id="basicForm:imageLink" href="#" style="someStyle"
onclick="document.forms['basicForm']['basicForm:_idcl'].value='basicForm:imageLink';
document.forms['basicForm'].submit(); return false;"><img
src="duke.gif;jsessionid=D89943C1230B2E4CF4CF06F45B16624B" alt="" /></a>
+ <a id="basicForm:imageLink" href="#" style="someStyle"
onclick="document.forms['basicForm']['basicForm:_idcl'].value='basicForm:imageLink';
document.forms['basicForm'].submit(); return false;"><img
src="duke.gif;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F" alt="" /></a>
</TD>
<TD>
- <img id="basicForm:graphicImage"
src="/test/duke.gif;jsessionid=D89943C1230B2E4CF4CF06F45B16624B"
style="someStyle" usemap="#map1" ismap="ismap" alt="" />
+ <img id="basicForm:graphicImage"
src="/test/duke.gif;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"
style="someStyle" usemap="#map1" ismap="ismap" alt="" />
</TD>
</TR>
@@ -169,7 +169,7 @@
- <a id="basicForm:hrefParamLink" href="#"
onclick="document.forms['basicForm']['basicForm:_idcl'].value='basicForm:hrefParamLink';document.forms['basicForm']['name'].value='horwat';document.forms['basicForm']['value'].value='password';
document.forms['basicForm'].submit(); return false;"><img
src="duke.gif;jsessionid=D89943C1230B2E4CF4CF06F45B16624B" alt="" /></a>
+ <a id="basicForm:hrefParamLink" href="#"
onclick="document.forms['basicForm']['basicForm:_idcl'].value='basicForm:hrefParamLink';document.forms['basicForm']['name'].value='horwat';document.forms['basicForm']['value'].value='password';
document.forms['basicForm'].submit(); return false;"><img
src="duke.gif;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F" alt="" /></a>
</TD>
</TR>
@@ -177,7 +177,7 @@
<TD>
- <a id="basicForm:outputLink"
href="test.html;jsessionid=D89943C1230B2E4CF4CF06F45B16624B"
class="hyperlinkClass">output link text</a>
+ <a id="basicForm:outputLink"
href="test.html;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"
class="hyperlinkClass">output link text</a>
</TD>
@@ -189,12 +189,12 @@
- <a id="basicForm:output_imageLink"
href="test.html;jsessionid=D89943C1230B2E4CF4CF06F45B16624B"
style="position: absolute; left: 96px; top: 168px"><img
src="duke.gif;jsessionid=D89943C1230B2E4CF4CF06F45B16624B" alt="" /></a>
+ <a id="basicForm:output_imageLink"
href="test.html;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"
style="position: absolute; left: 96px; top: 168px"><img
src="duke.gif;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F" alt="" /></a>
</TD>
<TD>
- <img id="basicForm:output_graphicImage"
src="/test/duke.gif;jsessionid=D89943C1230B2E4CF4CF06F45B16624B"
usemap="#map1" ismap="ismap" alt="" />
+ <img id="basicForm:output_graphicImage"
src="/test/duke.gif;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"
usemap="#map1" ismap="ismap" alt="" />
</TD>
</TR>
@@ -202,7 +202,7 @@
<TR>
<TD>
- <a id="basicForm:output_commandLink"
href="test.html;jsessionid=D89943C1230B2E4CF4CF06F45B16624B"
style="position: absolute; left: 96px; top: 168px"
class="hyperlinkClass">link text</a>
+ <a id="basicForm:output_commandLink"
href="test.html;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"
style="position: absolute; left: 96px; top: 168px"
class="hyperlinkClass">link text</a>
</TD>
</TR>
@@ -212,13 +212,13 @@
- <a id="basicForm:output_commandParamLink"
href="test.html;jsessionid=D89943C1230B2E4CF4CF06F45B16624B?name=horwat&value=password"
class="hyperlinkClass">link text</a>
+ <a id="basicForm:output_commandParamLink"
href="test.html;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F?name=horwat&value=password"
class="hyperlinkClass">link text</a>
</TD>
</TR>
<TR>
<TD>
- <a id="basicForm:output_hrefLink"
href="test.html;jsessionid=D89943C1230B2E4CF4CF06F45B16624B"><img
src="duke.gif"></a>
+ <a id="basicForm:output_hrefLink"
href="test.html;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F"><img
src="duke.gif"></a>
</TD>
</TR>
@@ -228,7 +228,7 @@
- <a id="basicForm:output_hrefParamLink"
href="test.html;jsessionid=D89943C1230B2E4CF4CF06F45B16624B?name=horwat&value=password"><img
src="duke.gif;jsessionid=D89943C1230B2E4CF4CF06F45B16624B" alt="" /></a>
+ <a id="basicForm:output_hrefParamLink"
href="test.html;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F?name=horwat&value=password"><img
src="duke.gif;jsessionid=1FA4AE40978CAEAD1EB29E903EE13A3F" alt="" /></a>
</TD>
</TR>
@@ -664,7 +664,7 @@
- <table
id="basicForm:ManyApples3" class="styleClass" style="someStyle">
+ <table border="1"
id="basicForm:ManyApples3" class="styleClass" style="someStyle">
<tr>
<td>
<label class="disabledClass"><input name="basicForm:ManyApples3"
value="0" type="checkbox" disabled="disabled" accesskey="A"
tabindex="3"> zero</input></label></td>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_javaserverfaces.dev.java.net
For additional commands, e-mail: dev-help_at_javaserverfaces.dev.java.net