Hi Thomas
I have checked a part of the javadoc, it looks good, and the tests looks
good too.
I would like to ask you a favor. I have been working on a CDI annotation
that uses this API to bind components into CDI beans. Attached to this mail
there is the code implementing this feature. It would be great if you can
help with this and include it in the branch you are working on in Mojarra,
since this feature relies on the API you are working on to locate the
component and create the proxy.
Could you please take a look at the code attached to this mail and if you
have some time please include it in Mojarra with the Search Expression API?
Thanks a lot for your attention.
regards,
Leonardo Uribe
2016-12-27 15:53 GMT-05:00 Thomas Andraschko <andraschko.thomas_at_gmail.com>:
> Hi all,
>
> today i commited a 90% finished version of JAVASERVERFACES_SPEC_PUBLIC-1238
> in my fork:
> https://github.com/tandraschko/mojarra/commits/master
>
> Whats currently missing:
>
> - JavaDoc on class SearchExpressionHandler / SearchKeywordResolver
> - Improving javadocs
> - Integration in existing components (f:ajax, h:outputLabel, ...)
> - new hint for composite and cc:editableValueHolder; currently discussing with Leo
> - integration test for existing components
>
>
> I think the best example to describe the API is the unit test, which
> contains ~40 tests (90% of the test cases of the PrimeFaces implementation):
>
> https://github.com/tandraschko/mojarra/blob/94ff5a11b3ec88f157d99131cf5414
> 8c7dbff99a/test/unit/src/test/java/javax/faces/component/
> SearchExpressionHandlerTest.java
>
> If anyone would like to review, please do!
>
> If anything works as expected, it will by finished by end of the week.
>
> Regards,
> Thomas
>