users@javaserverfaces-spec-public.java.net

[jsr344-experts mirror] [jsr344-experts] Re: 1137 non-servlet environment requirement

From: Edward Burns <edward.burns_at_oracle.com>
Date: Wed, 19 Dec 2012 14:16:39 -0800

>>>>> On Wed, 19 Dec 2012 13:51:56 -0800, Edward Burns <edward.burns_at_oracle.com> said:

>>>>> On Mon, 17 Dec 2012 19:12:31 -0500, Neil Griffin <neil.griffin_at_portletfaces.org> said:
NG> Hi Ed,
NG> The JSF 2.1 JavaDocs for ExternalContext#encodeNamespace(String) [1] indicate the following:

NG> * <p><em>Servlet:</em> The input value must be returned unchanged.</p>
NG> *
NG> * @param name Name to be encoded
NG> *
NG> * @throws NullPointerException if <code>name</code>
NG> * is <code>null</code>

NG> Having said that, I would like to direct your attention to issue 1137 [2]. Although the issue is marked as "Open," the JSF 2.2 JavaDocs for ExternalContext have changed the throws requirement to the following:

NG> * @throws NullPointerException <span class="changed_modified_2_2">
NG> * if running in a non-servlet environment and <code>name</code> is
NG> * <code>null</code></span>.

NG> Can you clarify as to why this requirement is now restricted to a
NG> non-servlet (portlet) environment? I think it might be best to
NG> simply remove this change from the JSF 2.2 JavaDocs and mark the
NG> 1137 issue as "WontFix".

EB> I'm taking the matter up with the reporter.

How about we just remove the @throws clause from the javadoc entirely?

Ed

-- 
| edward.burns_at_oracle.com | office: +1 407 458 0017
| homepage:               | http://ridingthecrest.com/