jsr372-experts@javaserverfaces-spec-public.java.net

[jsr372-experts] Re: [1103-IterableInUIRepeatUIData] ACTION

From: manfred riem <manfred.riem_at_oracle.com>
Date: Fri, 20 Feb 2015 09:51:32 -0600

Hi all,

Unless there are any objections voiced before EOB next Friday (2/27) I
am going ahead with committing this contribution from Arjan.

Thanks!
Manfred

On 2/19/15, 5:52 PM, arjan tijms wrote:
> Hi,
>
> On Thu, Feb 19, 2015 at 12:00 PM, Bauke Scholtz<balusc_at_gmail.com> wrote:
>> Would be even more cool if it transparently recognizes Map like c:forEach so
>> we don't need value="#{bean.map.entrySet()}" everytime.
> I created https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1364
> to track adding support for Map as well.
>
> Anyone else has any specific thoughts about adding support for Map in
> addition to adding support for Iterable?
>
> Kind regards,
> Arjan Tijms
>
>
>
>> Cheers, B
>>
>> On Wed, Feb 18, 2015 at 6:11 PM, arjan tijms<arjan.tijms_at_gmail.com> wrote:
>>> Hi,
>>>
>>> As a relatively small thing that was left open from 2.2; issue 1103
>>> deals with extending the support that 2.2 added for Collection in
>>> UIData to UIRepeat, and additionally upgrading the support for both to
>>> Iterable.
>>>
>>> I created a changebundle for that here:
>>> https://java.net/jira/secure/attachment/54434/changebundle.txt
>>>
>>> I think it's a fairly low impact change; the test for iterable is the
>>> last test, so for UIData the existing code will hit first for List and
>>> then Collection if any such types are passed in, and only if the type
>>> is none of these, but is Iterable, will the Iterable test hit and use
>>> a new IterableDataModel.
>>>
>>> For UIRepeat there never was Collection support, so there the code
>>> will hit if a Collection is passed in, as well as when an Iterable is
>>> passed in.
>>>
>>> As for the implementation code, the IterableDataModel that is used has
>>> been field tested in OmniFaces for some time now.
>>>
>>> Thoughts?
>>>
>>> Kind regards,
>>> Arjan Tijms
>>