Hi Bongjae,
> I implemented thrift server and client modules which based on Grizzly v2.
thank you very much for your contribution!
>
> Thrift site is http://thrift.apache.org .
>
> And Netty is already supporting thrift server and client modules.
>
> Netty tool site is https://github.com/cgbystrom/netty-tools
>
> So I tried to support them using Grizzly for performance improvement.
>
> I attached sources and test codes. Grizzly-thrift codes are located at
> modules/thrift/src/main and please read the README file. :)
> Could you please review them?
Can I suggest you move this code to Grizzly git repository under extras
directory for now, so it will simplify development for you and reviewing
for folks who's interested.
The code looks fine in general.
The most important thing, which is probably missed (if I'm not missing
anything), in the ThriftFrameFilter there is no logic, which handles
situation when input Buffer contains more than 1 thrift packet (you can
see the GIOP sample) to see how we propose to handle this (splitting
buffer etc).
Hope this will help.
Thanks.
WBR,
Alexey.