On Thu, Sep 29, 2011 at 10:30 PM, Oleksiy Stashok
<oleksiy.stashok_at_oracle.com> wrote:
>
>>>> we started to evaluate migration of our code from 1.9.x to 2.x.
>>>> While new filter implementation looks like more natural some
>>>> low-level functionality get lost or become more difficult to use.
>>>>
>>>>
>>>> in org.glassfish.grizzly.SocketBinder
>>>>
>>>> bind(String host, PortRange portRange, int backlog)
>>>>
>>>> takes String hostname as argument. This makes impossible to bind to any
>>>> interface. InetAddress instead of String will probably more useful.
>>>
>>> Have you tried "0.0.0.0"? Pls. file an issue - we'll fix it asap.
>>
>> yes, that works! ( 'String host' still looks strange to me)
>
> The patch is welcome ;)
>
>>>> org.glassfish.grizzly.Transport does not have a reliable way to
>>>> find out underling protocol ( well, instanceof is not a best way to go).
>>>
>>> Hmm... Can you pls. share your code related to this problem? Pretty sure
>>> we
>>> can find solution for it.
>>>
>> have a look here:
>>
>>
>> http://code.google.com/p/nio-jrpc/source/browse/src/org/dcache/xdr/RpcProtocolPaser.java#144
>>
>> and here:
>>
>>
>> http://code.google.com/p/nio-jrpc/source/browse/src/org/dcache/xdr/ProtocolKeeperFilter.java
>>
>>
>> This is required while sun-rpc messages arrive in fragments over TCP
>> and as a single messages in case of UDP.
>
> IMO it may look even nicer if you have 2 different Filters responsible for
> parsing, one for TCP another to UDP? :)
>
I think you are right.
Tigran.
> Thanks.
>
> WBR,
> Alexey.
>
>>>> And the last point - it looks like I got a 10% performance increase with
>>>> 2.1.3 over 1.9.19.
>>>
>>> Sounds good :))
>>>
>>> If you need more info - just let us know.
>>>
>>> Thanks.
>>>
>>> WBR,
>>> Alexey.
>>>
>>>> Thanks,
>>>> Tigran.
>>>>
>>>
>
>