Re: javax.servlet.* dependency of grizzly-servlet-deployer.jar

From: Bongjae Chang <carryel_at_korea.com>
Date: Thu, 27 Aug 2009 17:34:45 +0900

Thank you, Hubert.

After I test your patch again, I will open an issue tracker and commit it.

Thanks!

--
Bongjae Chang

  ----- Original Message -----
  From: Hubert Iwaniuk
  To: dev_at_grizzly.dev.java.net
  Sent: Wednesday, August 26, 2009 6:36 PM
  Subject: Re: javax.servlet.* dependency of grizzly-servlet-deployer.jar

  Yo!

  Attached patch doesn't have this error. If you find it working, please fill free to commit :)

  Cheers,

  � � Hubert.

  On Wed, Aug 26, 2009 at 11:08 AM, Bongjae Chang <carryel_at_korea.com> wrote:

    Hi Hubert,
    �
    It works well except for warning messages like this.
    �
    ---
    D:\grizzly\code\modules\http-servlet-deployer>mvn
    [INFO] Scanning for projects...
    WAGON_VERSION: 1.0-beta-1
    [INFO] ------------------------------------------------------------------------
    [INFO] Building grizzly-servlet-deployer
    [INFO]� � � task-segment: [install]
    [INFO] ------------------------------------------------------------------------
    ...
    [INFO] Building jar: D:\grizzly\code\modules\http-servlet-deployer\target\grizzly-servlet-deployer-1
    .9.18-SNAPSHOT.jar
    [INFO] [bundle:bundle {execution: osgi-bundle}]
    [WARNING] Warning building bundle com.sun.grizzly:grizzly-servlet-deployer:jar:1.9.18-SNAPSHOT : The
    re are split packages, use directive -split-package:=(merge-first|merge-last) on instruction to get
    rid of this warning: com.sun.grizzly.comet, classpath: [Jar:., Jar:grizzly-compat, Jar:grizzly-comet
    , Jar:grizzly-http, Jar:grizzly-framework, Jar:grizzly-utils, Jar:grizzly-rcm, Jar:grizzly-portunif,
    � Jar:grizzly-cometd, Jar:servlet-api, Jar:grizzly-http-servlet] from: C:\Documents and Settings\carr
    yel\.m2\repository\com\sun\grizzly\grizzly-comet\1.9.18-SNAPSHOT\grizzly-comet-1.9.18-SNAPSHOT.jar
    [WARNING] Warning building bundle com.sun.grizzly:grizzly-servlet-deployer:jar:1.9.18-SNAPSHOT : The
    re are split packages, use directive -split-package:=(merge-first|merge-last) on instruction to get
    rid of this warning: com.sun.grizzly.comet.concurrent, classpath: [Jar:., Jar:grizzly-compat, Jar:gr
    izzly-comet, Jar:grizzly-http, Jar:grizzly-framework, Jar:grizzly-utils, Jar:grizzly-rcm, Jar:grizzl
    y-portunif, Jar:grizzly-cometd, Jar:servlet-api, Jar:grizzly-http-servlet] from: C:\Documents and Se
    ttings\carryel\.m2\repository\com\sun\grizzly\grizzly-comet\1.9.18-SNAPSHOT\grizzly-comet-1.9.18-SNA
    PSHOT.jar
    ...
    ---
    �
    So I tried to edit your patch simply.
    �
    Index: modules/http-servlet-deployer/pom.xml
    ===================================================================
    --- modules/http-servlet-deployer/pom.xml� (revision 3546)
    +++ modules/http-servlet-deployer/pom.xml� (working copy)
    @@ -23,9 +23,7 @@
    � � � � � � � � � � � � � � � � <configuration>
    � � � � � � � � � � � � � � � � � � � � <instructions>
    � � � � � � � � � � � � � � � � � � � � � � � � <Import-Package>*</Import-Package>
    -� � � � � � � � � � � � � � � � � � � � � � � <Export-Package>com.sun.enterprise.web.connector.grizzly.comet.*,com.sun.grizzly.*;-split-package:=merge-first,javax.servlet.*;-split-package:=merge-first</Export-Package>
    -� � � � � � � � � � � � � � � � � � � � � � � <Embed-Dependency>com.sun.grizzly;scope=runtime</Embed-Dependency>
    -� � � � � � � � � � � � � � � � � � � � � � � <Main-Class>com.sun.grizzly.http.servlet.deployer.GrizzlyWebServerDeployer</Main-Class>
    +� � � � � � � � � � � � � � � � � � � � � � � <Export-Package>com.sun.grizzly.*;-split-package:=merge-first</Export-Package>
    � � � � � � � � � � � � � � � � � � � � </instructions>
    � � � � � � � � � � � � � � � � � � � � <unpackBundle>true</unpackBundle>
    � � � � � � � � � � � � � � � � </configuration>
    �
    Then, warning messages are removed.
    �
    Thanks!
    �
    --
    Bongjae Chang
    �
    �
      ----- Original Message -----
      From: Hubert Iwaniuk
      To: dev_at_grizzly.dev.java.net
      Sent: Wednesday, August 26, 2009 5:30 PM
      Subject: Re: javax.servlet.* dependency of grizzly-servlet-deployer.jar

      Hi Bongjae,

      You're right normal http-servlet-deployer should only declare dependency on servlet-api, and http-servlet-deployer-bundle should include it.
      Can you please give a try to attached patch?

      Cheers,
      � � Hubert.

      2009/8/26 Bongjae Chang <carryel_at_korea.com>

        Hi,
        �
        When I used grizzly-servlet-deployer.jar library in our product(Web Application Server) which is supporting JAVAEE6(using Sevlet 3.0)� experimentally,
        �
        I met� some compiling problems because of javax.servlet.* classes.
        �
        It seems that grizzly-servlet-deployer.jar has Servlet 2.5 APIs by default.
        �
        So I am curious to know why the library should include the javax.servlet.* classes.
        �
        I think that the library is not a bundle like grizzly-http-servlet-deployer.jar.
        �
        What do you think?
        �
        --
        Bongjae Chang

--------------------------------------------------------------------------

      ---------------------------------------------------------------------
      To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
      For additional commands, e-mail: dev-help_at_grizzly.dev.java.net

------------------------------------------------------------------------------

  ---------------------------------------------------------------------
  To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
  For additional commands, e-mail: dev-help_at_grizzly.dev.java.net