From: Bongjae Chang <carryel_at_korea.com>
Date: Wed, 13 May 2009 14:55:43 +0900

Hi,

This is a very trival bug.

When I reviewed the RoundRobinSelectorHandler.java code, I found that the array's index could become to be a negative number if roundRobinCounter++ will be over 0x80000000 value.


See the following:

RoundRobinSelectorHandler#nextController()
---
...
private int roundRobinCounter;
...
private ReadController nextController() {
    return rrControllers[roundRobinCounter++ % rrControllers.length];
}
---


If the server will live for a long time and accept many clients, an IndexOutOfBoundsException will be able to be thrown and the server will be not able to accept any clients any longer.


Here is sample.

RoundRobinSelectorHandler#nextController()
---
private ReadController nextController() {
    int index = roundRobinCounter++ % rrControllers.length;
    if( roundRobinCounter < 0 )
        roundRobinCounter = 0;
    return rrControllers[index];
}
---


Thanks.

--
Bongjae Chang