dev@grizzly.java.net

Re: DefaultThreadPool

From: Minoru Nitta <minoru.nitta_at_jp.fujitsu.com>
Date: Mon, 18 May 2009 09:27:08 +0900

Salut Alexey,


> Hi Minoru,
>
> >
> > Now thread pool size is automatically configured in Controller class.
> > So maximum pool size and core pool size parameters of
> > DefaultThreadPool
> > conctructor are actually ignored. These parameters should be removed
> > from the constructor. What do you think?
> Grizzly automatically configures thread pool, only when you create new
> Controller. But after that, everyone is free to change pool settings,
> or even provide custom thread pool, which will not be reconfigured by
> Grizzly.
> So, IMHO, DefaultThreadPool constructor with parameters may be still
> useful.


You are right. DefaultThreadPool constructor with parameters are useful.

DefaultThreadPool constructor with parameters in creating a new
Controller is confusing to programmers (and in some cases, it may be
error prone). I suggest following two ideas:

a) maximum pool size and core pool size are auto-configured in
   default constructor of DefaultThreadPool.

or

b) Add a new method that specifies maximum pool size and core pool size
   are auto-configured to Controller class.

> WBR,
> Alexey.
> >
> >
> >
> > Minoru
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
> > For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
> >
>