dev@grizzly.java.net

Re: SSLConfig

From: Bruno Harbulot <Bruno.Harbulot_at_manchester.ac.uk>
Date: Mon, 06 Apr 2009 10:39:29 +0100

Hi Oleksiy,

(Sorry, I hadn't seen this e-mail before replying to the other one a few
minutes ago.)
Oleksiy Stashok wrote:
> Hi Bruno,
>
>>> If you don't mind trying to have default values closer to those of
>>> the JSSE Ref. Guide, I'll try to come up with a patch over the next
>>> few days.
>>> Not only that I don't mind, I certainly would like to see it working
>>> better.
>>> I haven't follow Ref Guide, I didn't even know that it existed.
>>
>> I've just sent a patch to issue #494. Please let me know what you
>> think. (I wasn't sure about the Grizzly formatting conventions, so
>> I've used "Java conventions" in Eclipse.)
> Thank you very much for patch!
> +1 for it.
>
> Hubert, can you pls. check it will fine for default GWS security scenario?

I've changed two lines in the test unit.

In testStartSecureWithConfiguration(), I've set the password of the
keystore (because I've removed the default value 'changeit' in
SSLConfig). I don't think this will be an issue, since no one would you
a keystore without setting its password anyway (either explicitly with
the setter or read from the system property, which is still used).

I've also added gws.stop() in testStartSecureFailDefault(), so that, if
gws.start() didn't fail as intended, it would at least free the port for
the following tests.


> Thank you guys!

Happy to help!


Best wishes,

Bruno.