Missed two more :)
if ("tcpNoDelay".equals(propName)) {
embeddedHttp.setTcpNoDelay(toBoolean(propValue));
} else if ("traceEnabled".equals(propName)) {
embeddedHttp.setProperty(propName,
toBoolean(propValue));
the tcpNoDelay sounds like a Transport thing. not sure about
traceEnabled. NetworkListener?
Justin Lee wrote:
> OK. Updated those as well. What about default values? Should I just
> "cheat" by only applying non-null values? Seems simplest...
>
> Jeanfrancois Arcand wrote:
>> Salut,
>>
>>
>> Justin Lee wrote:
>>> I've updated the one pager with alexey's feedback. Any other
>>> thoughts before I go update the code? Can I delete the DTDs now
>>> that we're working with live java interfaces? Keeping both in sync
>>> in tedious and error prone...
>>>
>>
>> +1
>>
>>
>>> Oleksiy Stashok wrote:
>>>> Hi Justin,
>>>>
>>>> very great to see you're making good progress!!! :)
>>>> I'll just add comments on properties I have idea about, the rest
>>>> I'll leave for Jeanfrancois and Jan :)
>>>>
>>
>>
>>
>>>>
>>>>> GrizzlyServiceListener configures a *lot* of stuff based on
>>>>> <property> elements under <http-listener>. Some of that I can
>>>>> drop because we have config elements for them but not all. Things
>>>>> like comet support now have formal support but most of these
>>>>> others don't... What to do with those? Leave 'em? Add config
>>>>> elements to Http?
>>>>>
>>>>> bufferSize
>>>> add transport->buffer-size
>>>>
>>>>> use-nio-direct-bytebuffer
>>>> same as transport->byte-buffer-type (HEAD/DIRECT values are supported)
>>>>
>>>>> maxKeepAliveRequests
>>>> http->max-connections
>>>>
>>>>> authPassthro
>>>> ? no idea
>>
>> http
>>
>>>>
>>>>> compression
>>>>> compressableMimeType
>>>>> noCompressionUserAgents
>>>>> compressionMinSize
>>>>> restrictedUserAgents
>>>> go under http
>>>>
>>>>> rcmSupport
>>>> probably add http>enable-rcm-support
>>>>
>>>>>
>>>>> cometSupport
>>>> http->enable-comet-support
>>>>
>>>>> connectionUploadTimeout
>>>>> disableUploadTimeout
>>>> ? no idea
>>
>> Under http
>>>>
>>>>> proxiedProtocols
>>>> will be replaced with port-unification
>>>>
>>>>> chunkingDisabled
>>>>> chunking-disabled
>>>> IMHO we need to add http->chunking-disabled
>>
>> +1
>>
>>>>
>>>>> crlFile
>>>> ? no idea
>>
>> Under ssl
>>
>>
>>>>
>>>>> trustAlgorithm
>>>>> trustMaxCertLength
>>>> IMHO it should be under ssl
>>>>
>>>>> uriEncoding
>>>> ? no idea.
>>
>> under http
>>
>>>>
>>>>> jkEnabled
>>>> Seems we don't need this anymore for grizzly config.
>>
>> Right...except where will we configure mod_jk from GF?
>>
>> A+
>>
>> -- Jeanfrancois
>>
>>>>
>>>> WBR,
>>>> Alexey.
>>>>
>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
>>> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
>> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
>