Hello Charlie,
I choose 2 mostly for the reason, that when we have several read threads
for one SelectorHandler - we're creating clones of Controller and
SelectorHandlers. These clones should share the same attribute set as
there master.
This means that master attributes parameter could not be null at the
time of copying. As currently we're creating clones (if have several
read threads) on initialization phase - it means attributes will be null
at that time, because of lazy initialization, so I decided to create a
small map, which will be shared among clones, because at that time we
don't know whether it will be used in future at all.
From other side, in setAttribute() method for Controller and
TCPSelectorHandler it makes sense to change constructor to default one,
as at that point we're sure attribute map will be really used.
What do you think?
Thanks.
WBR,
Alexey.
charlie hunt wrote:
> I noticed in the commit for attribute get/set support in Context that
> we have several Map initializations where the size of the HashMap
> instantiated is size 2.
>
> A couple questions:
> 1.) Why size 2 ?
> 2.) Can that initial size be acquired implicitly or be declared as a
> constant instead of using the hard coded number '2' ?
> 3.) Isn't size 2 pretty small for a HashMap? With a default load
> factor, that HashMap will get resized pretty quickly as entries are
> added. I don't know how many entries are expected to be typically to
> be put in that map?
>
> thanks,
>
> charlie ...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_grizzly.dev.java.net
> For additional commands, e-mail: dev-help_at_grizzly.dev.java.net
>