More comments on
http://wiki.glassfish.java.net/Wiki.jsp?page=GFV3JDBCOnePager&version=72
Section 4.1.12
Is the driver-classname attribute optional when the res-type ISN'T java.sql.Driver?
An aside: you use class-name and classname for new attributes in this one-pager...
Other attributes appear to use classname. you might want to consider making them
consistent.
Section 4.1.13
no comment here. may have comments in the section that this text references.
Section 4.1.14
Why not make the query available in the CLI?
Section 4.2
make these xrefs links... you should probably put them into the subsections of 4.1 where they are more useful.
Section 4.3, 4.4, 4.5, 4.6
no comment
Section 4.7
The --principalmap and --groupmap options are very similar to the --property option in other asadmin commands... They all allow the user to enter a list of pairs. The delimiter for --property is a ':' (colon). You might want to consider making that the delimiter for the lists of pairs for these two new options.
I have no comments on any other section of this one pager.
vbk
[Message sent by forum member 'vbkraemer' (vbkraemer)]
http://forums.java.net/jive/thread.jspa?messageID=325107