quality@glassfish.java.net

Re: FINAL REVIEW of gfv3 Admin Guide

From: Jan Luehe <Jan.Luehe_at_Sun.COM>
Date: Tue, 01 Dec 2009 13:59:15 -0800

Following are my comments, Dixie:

-------------------------------------------------------------------------
Modifying the Configuration a Web Application or Module

- Chapter title should be changed to "Modifying the Configuration
  <ADD>of</ADD> a Web Application or Module"

- Example 2-7 ("Redeploying a Web Application to Retain Sessions"):

I would change the example's title to "Retaining HTTP Session State during
Redeployment"

- Example 2-21 ("Setting a Servlet Context-Initialization Parameter
  for aWeb Application"):

Add a line break before "Command set-web-context-param executed
successfully"

-------------------------------------------------------------------------
Web Module Deployment Guidelines

- Virtual Servers:

Change marked with <ADD></ADD> in the following paragraph:

  "If you deploy a web application and do not specify any assigned
  virtual servers, the web application is assigned to all
  currently-defined virtual servers <ADD>with the exception of the
  virtual server with id __asadmin, which is reserved for administrative
  purposes</ADD>."

- HTTP Sessions:

Please remove all existing text, including the Note. Use the following
instead:

  If a web application is undeployed, all its HTTP sessions will be
  invalidated and removed, unless the application is being undeployed as
  part of a redeployment and the keepSessions deployment property was
  set to true (see Example 2-7: Retaining HTTP Session State during
  Redeployment).

  During a server shutdown, all HTTP sessions of a web application will
  be persisted to the file specified by the session-manager property with
  name "sessionFilename" in the web application's sun-web.xml deployment
  descriptor. In order to prevent HTTP sessions from being persisted during
  a server shutdown, specify the "sessionFilename" property with an empty
  value, as follows:

    <sun-web-app>
      <session-config>
        <session-manager>
          <manager-properties>
            <property name="sessionFilename" value="" />
          </manager-properties>
        </session-manager>
      </session-config>
    </sun-web-app>

  The default location where HTTP sessions will be persisted during a
  server shutdown is given as
  domain-dir/generated/jsp/<module-name>/<module-name>_SESSIONS.ser

- JSP Precompilation:

The word "Preview" in "Sun GlassFish Enterprise Server v3 Preview
Application Development Guide" should be removed


Thanks,


Jan