quality@glassfish.java.net

Re: virtualservers in embedded gf

From: Judy Tang <Judy.J.Tang_at_Sun.COM>
Date: Sun, 18 Oct 2009 10:11:55 -0700

Hi Johan,

Thanks so much for testing in the weekend. A good catch :-)

Looking at your bug description, I am just so impressed that you gave
the solution, means you looked
into the code, you listed another related issue, means you did bug
search before you file this issue, very
nice !

I will help to follow up this issue.

Have a good Sunday !
Judy

------

INFO: webcontainer.webModuleNotLoadedNoVirtualServers
This is printed by com.sun.enterprise.web.WebContainer.loadWebModule (around
line 1498) since wmInfo.getVirtualServers() is empty.

From the output, you get the impression that deployment succeeded:
Oct 18, 2009 5:08:16 PM com.sun.enterprise.web.WebApplication start
INFO: Loading application HelloEmbedded at /HelloEmbedded
EmbeddedDeployer.deploy() returns a String, as can be expected on successful
deployment.

Solution: provide virtualservers in DeployParams.
 deployParams.virtualservers="server";

I think it might be better that if no virtualservers are specified, the default
one should be used. Or at least an error should be printed, not giving the user
the impression that deployment succeeded.

Related to #10301, but no NPE is thrown in this case.



Johan Vos wrote:
> If you deploy a WAR using the embedded API's, deployment fails without
> warning if you don't provide virtualservers info. That is, the deploy
> method returns correct, but no war is deployed. I filed #10385 for this.
>
> - Johan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: quality-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: quality-help_at_glassfish.dev.java.net
>