Re: Code review for Issue 1673, 2674 fails to deserialize from byte array when run underJava 6

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]

From: Tom Ware <tom.ware_at_oracle.com>
Date: Thu, 22 Mar 2007 13:05:38 -0400

Hi Wonseok,

Your changes look good.

-Tom

Wonseok Kim wrote:

> Hi Tom,
>
> Please review the fix. I also added a test.
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=1673
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=2674
>
> I found that there are other places using ClassLoader.loadClass()
> instead of Class.forName(classname, initialize, classloader), but
> those won't try to load array class - most of those is to load entity
> class. Thus I didn't modify those codes. Should we replace all
> ClassLoader.loadClass() with Class.forName(classname, initialize,
> classloader)?
>
> I ran tests in JDK 6, there was no problem.
>
> Thanks,
> -Wonseok
>
>