Hi Markus,
I took a look at your code and in general, it appears to work better
than the existing code. I suggest adding one additional operator overload:
The line:
addOperator(ExpressionOperator.simpleFunction(ExpressionOperator.Length,
"CHAR_LENGTH"));
in the previous version of the platform appears to allow Length to work
properly. It might be a good idea to add that function.
-Tom
Tom Ware wrote:
>Hi Markus,
>
> Do you also have changes to the VendorNameToPlatformMapping.properties
>you'd like to include?
>
>-Tom
>
>Markus KARG wrote:
>
>
>
>>Tom,
>>
>>
>>
>>
>>>I am copying the persistence list on this reply since there may be
>>>some people on the list that are interested.
>>>
>>>I believe there are two things we have to do.
>>>
>>>1. You had some concerns about the licensing. We need to alleviate
>>>those concerns. Hopefully some of the Sun folks have made some
>>>progress and can share it with us.
>>>2. We should get your code reviewed. When we all agree that it is in
>>>shape to check-in we will check it in. To get the code reviewed, I
>>>beleive the best strategy is to send it to the persistence list and
>>>request a review. Let me know if that makes sense to you.
>>>
>>>
>>>
>>>
>>there still is the issue with the jConnect bug that Sybase denies to fix
>>and the failed test "Query.setFirstResult". Is this a problem for
>>somebody? Maybe Tom knows how we can turn the sequence from "? = a" to
>>"a = ?" ?
>>
>>If nobody has a problem with that, I do not see a reason why not to
>>replace SQLAnyWherePlatform by my SQLAnywherPlatform.
>>
>>Attached is the code. Please give it a review. :-)
>>
>>Thanks
>>Markus
>>
>>
>>
>>
>
>
>
>