persistence@glassfish.java.net

Re: Code review for issue #1502

From: Tom Ware <tom.ware_at_oracle.com>
Date: Mon, 13 Nov 2006 13:03:36 -0500

Hi Sahoo,

  I just have one concern. Perhaps you can alleviate it.

  The fact that we have to return and empty iterator from the getEntries
method of URLArchive means we cannot detect classes that are in a jar.
Can the URL of a jar file listed in persistence.xml as a <jar-file> use
this kind of a URL? If so, doesn't the spec require us to be able to
detect the classes?

-Tom
 

Sanjeeb Kumar Sahoo wrote:

>Hi Tom,
>
>Please review the fix for issue #1502. It needs introduction of a new
>class called URLArchive in addition to the changes to two existing
>classes. Issue tracker has more details about the fix.
>
>Thanks,
>Sahoo
>
>