Re: Fix mapping of antlr exceptions to EJBQLException class (issue 1163)

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]

From: Tom Ware <tom.ware_at_oracle.com>
Date: Mon, 25 Sep 2006 15:18:26 -0400

Hi Michael,

The change looks good to me.

Thanks,
Tom

Michael Bouschen wrote:

>Hi Tom, hi Jielin,
>
>I fixed issue 1163: "EJBQLParser - null exception for invalid JPQL
>String": https://glassfish.dev.java.net/issues/show_bug.cgi?id=1163
>
>The attached jar JPQL-fix1163-060925.jar includes the code changes and a
>new test in entity-persistence-tests. I changed the method in
>EJBQLParserBase mapping the internal ANTLRException to the
>EJBQLException thrown to indicate an invalid query. The old
>implementation missed to handle some specific ANTLRExceptions, such that
>it returned null as the mapped EJBQLException.
>
>Thanks!
>
>Regards Michael
>
>