Hi Pramod,
I assume you mean issues 620 and 609.
In general the code looks good, my only concerns are related to testing.
- What platforms have you tested this on?
- Are the automated tests?
- What should our regression testing strategy be for these changes?
Thanks,
Tom
Pramod Gopinath wrote:
>Hi Tom
> Could U review the changes that I have made to solve the following
>issues :
>620 : Introduce support in java2db to create foreign key constraints
>610 : The foreign key fields should be of the same type and have the
>same size as the field that they are referring to
>
>The changes are all relevant to 1 one file :
>oracle/toplink/essentials/tools/schemaframework/DefaultTableGenerator.
>
>Thanks
>Pramod
>
>